netdev - Re: [PATCH net-next] bnx2x: namespace and dead code cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140113.120055.7725617708311037.davem@davemloft.net>
Date:	Mon, 13 Jan 2014 12:00:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	ariele@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bnx2x: namespace and dead code cleanups

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 9 Jan 2014 22:20:11 -0800

> Fix a bunch of whole lot of namespace issues with the Broadcom bnx2x driver
> found by running 'make namespacecheck'
> 
>  * global variables must be prefixed with bnx2x_
>     naming a variable int_mode, or num_queue is invitation to disaster
> 
>  * make local functions static
> 
>  * move some inline's used in one file out of header
>    (this driver has a bad case of inline-itis)
> 
>  * remove resulting dead code fallout
>  	 bnx2x_pfc_statistic,
> 	 bnx2x_emac_get_pfc_stat
>  	 bnx2x_init_vlan_mac_obj,
>    Looks like vlan mac support in this driver was a botch from day one
>    either never worked, or not implemented or missing support functions
> 
> Compile tested only.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html