netdev - RE: [PATCH 07/15] net: i40e calls skb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B7312BADC@ORSMSX101.amr.corp.intel.com>
Date:	Mon, 13 Jan 2014 21:53:32 +0000
From:	"Brown, Aaron F" <aaron.f.brown@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	Tom Herbert <therbert@...gle.com>
CC:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH 07/15] net: i40e calls skb_set_hash

> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Jeff Kirsher
> Sent: Wednesday, December 18, 2013 12:40 AM
> To: Tom Herbert
> Cc: David Miller; netdev
> Subject: Re: [PATCH 07/15] net: i40e calls skb_set_hash
> 
> On Tue, Dec 17, 2013 at 11:27 PM, Tom Herbert <therbert@...gle.com> wrote:
> > Drivers should call skb_set_hash to set the hash and its type in an
> > skbuff.
> >
> > Signed-off-by: Tom Herbert <therbert@...gle.com>
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> 
> I have added this patch to my queue, thanks Tom.

And unfortunately it fails to compile giving the following error:
------------------------------------------------------------------------
drivers/net/ethernet/intel/i40e/i40e_txrx.c: In function 'i40e_clean_rx_irq':
drivers/net/ethernet/intel/i40e/i40e_txrx.c:1088: error: too few arguments to function 'i40e_rx_checksum'