lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2014 06:36:41 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Andrew Vagin <avagin@...allels.com> Cc: Florian Westphal <fw@...len.de>, Andrey Vagin <avagin@...nvz.org>, netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, vvs@...nvz.org, Pablo Neira Ayuso <pablo@...filter.org>, Patrick McHardy <kaber@...sh.net>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, "David S. Miller" <davem@...emloft.net>, Cyrill Gorcunov <gorcunov@...nvz.org> Subject: Re: [PATCH] netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get (v3) On Tue, 2014-01-14 at 14:51 +0400, Andrew Vagin wrote: > I think __nf_conntrack_alloc must use atomic_inc instead of > atomic_set. And we must be sure, that the first object from a new page is > zeroized. No you can not do that, and we do not need. If a new page is allocated, then you have the guarantee nobody can ever uses it, its content can be totally random. Only 'living' objects, the ones that were previously inserted in the hash table, can be found, and their refcnt must be accurate. A freed object has refcnt == 0, thats the golden rule. When the page is freed (after RCU grace period), nobody cares of refcnt anymore. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists