netdev - Re: [PATCH net-next 2/2] net: rename sysfs symlinks on device name change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140114191417.GB9942@redhat.com>
Date:	Tue, 14 Jan 2014 20:14:17 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Ding Tianhong <dingtianhong@...wei.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net-next 2/2] net: rename sysfs symlinks on device name
 change

On Tue, Jan 14, 2014 at 10:30:56AM -0800, Cong Wang wrote:
>On Tue, Jan 14, 2014 at 8:36 AM, Veaceslav Falico <vfalico@...hat.com> wrote:
>> +void netdev_adjacent_rename_links(struct net_device *dev, char *oldname)
>> +{
>> +       struct netdev_adjacent *iter;
>> +
>> +       list_for_each_entry(iter, &dev->adj_list.upper, list) {
>> +               netdev_adjacent_sysfs_del(iter->dev, oldname,
>> +                                         &iter->dev->adj_list.lower);
>> +               netdev_adjacent_sysfs_add(iter->dev, dev,
>> +                                         &iter->dev->adj_list.lower);
>> +       }
>> +
>> +       list_for_each_entry(iter, &dev->adj_list.lower, list) {
>> +               netdev_adjacent_sysfs_del(iter->dev, oldname,
>> +                                         &iter->dev->adj_list.upper);
>> +               netdev_adjacent_sysfs_add(iter->dev, dev,
>> +                                         &iter->dev->adj_list.upper);
>> +       }
>> +}
>> +EXPORT_SYMBOL(netdev_adjacent_rename_links);
>
>Since it is only used within net/core/dev.c, why do you make it extern
>and export it? It can become static.

Hm, good point, exported it automatically, didn't realise that dev_rename()
is also in dev.c.

Will send v2.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html