netdev - Re: [PATCH net 0/2] bonding: ensure that the TSO being set on bond master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52D49BA4.7040706@huawei.com>
Date:	Tue, 14 Jan 2014 10:06:28 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<fubar@...ibm.com>, <vfalico@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net 0/2] bonding: ensure that the TSO being set on bond
 master

On 2014/1/14 3:15, David Miller wrote:
> From: Ding Tianhong <dingtianhong@...wei.com>
> Date: Wed, 8 Jan 2014 15:28:21 +0800
> 
>> The commit b0ce3508(bonding: allow TSO being set on bonding master)
>> has make the TSO being set for bond dev, but in some situation, if
>> the slave did not have the NETIF_F_SG features, the bond master will
>> miss the TSO features in netdev_fix_features because the TSO is
>> depended on SG. So I have to add SG and TSO features on bond master
>> together.
>>
>> The function netdev_add_tso_features() was only be used for bonding,
>> so no need to export it in netdevice.h, remove it and add it to bonding.
> 
> As far as I can tell from the discussion, there is some issue wrt. TSO
> about what happens if SG is not supported by some of the slaves.
> 
>>>From my perspective it appears that some changes to these patches are
> necessary to handle that correctly.
> 
> So I am going to mark them as "Changes Requested" in patchwork.
> 
> If this is not the case, please resubmit these changes with appropriate
> explanations added to the commit message(s).
> 
> Thanks.
> 
> 

Ok, thanks.

Regards
Ding



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html