[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140113.222252.1955015452268147519.davem@davemloft.net>
Date: Mon, 13 Jan 2014 22:22:52 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: vfalico@...hat.com
Cc: netdev@...r.kernel.org, dingtianhong@...wei.com, fubar@...ibm.com,
andy@...yhouse.net
Subject: Re: [PATCH v4 net-next 0/3] bonding: fix bond_3ad RCU usage
From: Veaceslav Falico <vfalico@...hat.com>
Date: Fri, 10 Jan 2014 11:59:42 +0100
> While digging through bond_3ad.c I've found that the RCU usage there is
> just wrong - it's used as a kind of mutex/spinlock instead of RCU.
>
> v3->v4: remove useless goto and wrap __get_first_agg() in proper RCU.
>
> v2->v3: make bond_3ad_set_carrier() use RCU read lock for the whole
> function, so that all other functions will be protected by RCU as well.
> This way we can use _rcu variants everywhere.
>
> v1->v2: use generic primitives instead of _rcu ones cause we can hold RTNL
> lock without RCU one, which is still safe.
>
> This patchset is on top of bond_3ad.c cleanup:
> http://www.spinics.net/lists/netdev/msg265447.html
Series applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists