| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2014 11:02:55 +0000 From: Andrew Bennieston <andrew.bennieston@...rix.com> To: Wei Liu <wei.liu2@...rix.com>, Annie Li <Annie.li@...cle.com> CC: <netdev@...r.kernel.org>, <ian.campbell@...rix.com>, <xen-devel@...ts.xen.org> Subject: Re: [Xen-devel] [PATCH net-next] xen-netfront: clean up code in xennet_release_rx_bufs On 15/01/14 10:07, Wei Liu wrote: > On Fri, Jan 10, 2014 at 06:48:38AM +0800, Annie Li wrote: >> Current netfront only grants pages for grant copy, not for grant transfer, so >> remove corresponding transfer code and add receiving copy code in >> xennet_release_rx_bufs. >> > > This path seldom gets call -- not that many people unload xen-netfront > driver. If Annie has tested this patch and it works as expected I think > it's fine. > In XenServer we have seen a number of cases where unplugging and replugging VIFs results in leakage of grant references, eventually leading to a case where you cannot plug a VIF (after ~ 400 such cycles)... It's worth pointing out, as far as this patch is concerned, that gnttab_end_foreign_access() can fail, which is not taken into account here. Andrew. > I'm not netfront maintainer but I'm happy to add > Acked-by: Wei Liu <wei.liu2@...rix.com> > if Annie confirms she's tested this patch. > > Wei. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@...ts.xen.org > http://lists.xen.org/xen-devel > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists