netdev - Re: [PATCH] ipv4: delete the statements limit icmp message in ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jan 2014 17:04:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	duanj.fnst@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: delete the statements limit icmp message in
 ip_error()

From: Duan Jiong <duanj.fnst@...fujitsu.com>
Date: Sun, 12 Jan 2014 17:52:20 +0800

> Because after the icmp_send() is called, the icmpv4_xrlim_allow()
> will be called to limit the icmp message too.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>

icmpv4_xrlim_allow() is different from what this code is doing.

There are seperate controls for ip_error() reporting, namely:

> -		if (peer->rate_tokens > ip_rt_error_burst)
 ...
> -		if (peer->rate_tokens >= ip_rt_error_cost)

And this is the only place where that is taken into account.

The icmpv4_xrlim_allow() is a top level limiting on all ICMPs,
this function is limiting specific kinds.

I am not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html