netdev - Re: [PATCH 14/14] batman-adv: drop dependency against CRC16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D68A1C.3080302@meshcoding.com>
Date:	Wed, 15 Jan 2014 14:16:12 +0100
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	davem@...emloft.net
CC:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCH 14/14] batman-adv: drop dependency against CRC16

On 13/01/14 23:31, Antonio Quartulli wrote:
> The crc16 functionality is not used anymore, therefore
> we can safely remove the dependency in the Kbuild file.
> 
> Signed-off-by: Antonio Quartulli <antonio@...hcoding.com>

David,

we just realized that this dependency is still needed by our module.
(also thanks to Fengguang Wu build bot!)

Could you please revert this patch only?
Or do you want me to send the "revert" on the netdev ml as a patch (or
pull request)?


Thanks a lot!


> ---
>  net/batman-adv/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
> index fa780b7..2b2dc47 100644
> --- a/net/batman-adv/Kconfig
> +++ b/net/batman-adv/Kconfig
> @@ -5,7 +5,6 @@
>  config BATMAN_ADV
>  	tristate "B.A.T.M.A.N. Advanced Meshing Protocol"
>  	depends on NET
> -	select CRC16
>  	select LIBCRC32C
>          default n
>  	help
> 


-- 
Antonio Quartulli




Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)