netdev - Re: [Xen-devel] [PATCH net-next] xen-netfront: add support for IPv6 offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <52D6BF630200007800113EFB@nat28.tlf.novell.com>
Date:	Wed, 15 Jan 2014 16:03:31 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Andrew Cooper" <Andrew.Cooper3@...rix.com>,
	"Paul Durrant" <Paul.Durrant@...rix.com>
Cc:	"David Vrabel" <david.vrabel@...rix.com>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH net-next] xen-netfront: add support for
 IPv6 offloads

>>> On 15.01.14 at 16:54, Paul Durrant <Paul.Durrant@...rix.com> wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@...rix.com]
>> On 15/01/14 15:18, Paul Durrant wrote:
>> > +	err = xenbus_printf(xbt, dev->nodename, "feature-gso-tcpv6", "%d", 1);
>> 
>> "%d", 1 results in a constant string.  xenbus_write() would avoid a
>> transitory memory allocation.
> 
> This code is consistent with all the other xenbus_printf()s in the 
> neighbourhood and does it really matter?

I think we should always strive to have the simplest possible code
that fulfills the purpose. And hence we shouldn't be setting further
bad precedents. (In fact I have a patch queued to replace all the
unnecessary xenbus_printf()s with xenbus_write()s on
linux-2.6.18-xen.hg, and may look into porting this to the
respective upstream components.)

Jan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html