netdev - Re: [PATCH][net-next] gianfar: Fix portabilty issues for ethtool and ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140115.143954.1643141626782262450.davem@davemloft.net>
Date:	Wed, 15 Jan 2014 14:39:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH][net-next] gianfar: Fix portabilty issues for ethtool
 and ptp

From: Claudiu Manoil <claudiu.manoil@...escale.com>
Date: Tue, 14 Jan 2014 15:35:00 +0200

> Fixes unhandled register write in gianfar_ethtool.c.
> Fixes following endianess related functional issues,
> reported by sparse as well, i.e.:
> 
> gianfar_ethtool.c:1058:33: warning:
>     incorrect type in argument 1 (different base types)
>     expected unsigned int [unsigned] [usertype] value
>     got restricted __be32 [usertype] ip4src
> 
> gianfar_ethtool.c:1164:33: warning:
>     restricted __be16 degrades to integer
> 
> gianfar_ethtool.c:1669:32: warning:
>     invalid assignment: ^=
>     left side has type restricted __be16
>     right side has type int
> 
> Solves all the sparse warnings for mixig normal pointers
> with __iomem pointers for gianfar_ptp.c, i.e.:
> gianfar_ptp.c:163:32: warning:
>     incorrect type in argument 1 (different address spaces)
>     expected unsigned int [noderef] <asn:2>*addr
>     got unsigned int *<noident>
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html