netdev - Re: [PATCH net-next v3 2/2] stmmac: Fix kernel crashes for jumbo frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140115.145725.801343084524328515.davem@davemloft.net>
Date:	Wed, 15 Jan 2014 14:57:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vbridgers2013@...il.com
Cc:	bhutchings@...arflare.com, devicetree@...r.kernel.org,
	netdev@...r.kernel.org, peppe.cavallaro@...com, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	dinguyen@...era.com, rayagond@...avyalabs.com
Subject: Re: [PATCH net-next v3 2/2] stmmac: Fix kernel crashes for jumbo
 frames

From: Vince Bridgers <vbridgers2013@...il.com>
Date: Tue, 14 Jan 2014 14:44:35 -0600

> On Tue, Jan 14, 2014 at 1:53 PM, Ben Hutchings
> <bhutchings@...arflare.com> wrote:
>> On Tue, 2014-01-14 at 11:17 -0600, Vince Bridgers wrote:
>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> @@ -51,6 +51,10 @@ static int stmmac_probe_config_dt(struct platform_device *pdev,
>>>       plat->mdio_bus_data = devm_kzalloc(&pdev->dev,
>>>                                          sizeof(struct stmmac_mdio_bus_data),
>>>                                          GFP_KERNEL);
>>> +     /* Set the maxmtu to a default of 1500 in case the
>>> +      * parameter is not present in the device tree
>>> +      */
>>> +     plat->maxmtu = JUMBO_LEN;
>>
>> The comment disagrees with the definition of JUMBO_LEN.
> 
> ok, I'll address the comment inconsistency.

Therefore I'm expecting to see a v4 of this series at some point,
thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html