netdev - Re: [PATCH net-next] net: eth_type_trans() should use skb_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140116.153044.1318855011954380596.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 15:30:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: eth_type_trans() should use
 skb_header_pointer()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Jan 2014 15:03:31 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> eth_type_trans() can read uninitialized memory as drivers
> do not necessarily pull more than 14 bytes in skb->head before
> calling it.
> 
> As David suggested, we can use skb_header_pointer() to
> fix this without breaking some drivers that might not expect
> eth_type_trans() pulling 2 additional bytes.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> ---
> Since this bug is very old, I cooked the patch on net-next

Applied, thanks a lot Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html