netdev - Re: [PATCH V3 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D91F37.8060602@enst-bretagne.fr>
Date:	Fri, 17 Jan 2014 13:16:55 +0100
From:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>
To:	netdev@...r.kernel.org,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH V3 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag
 to IPV6_FL_A_GET

Le 17/01/2014 02:27, Hannes Frederic Sowa a écrit :
> On Thu, Jan 16, 2014 at 05:19:16PM +0100, Florent Fourcot wrote:
>> @@ -1000,6 +1002,8 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb)
>>  	ireq = inet_rsk(req);
>>  	ireq->ir_v6_rmt_addr = ipv6_hdr(skb)->saddr;
>>  	ireq->ir_v6_loc_addr = ipv6_hdr(skb)->daddr;
>> +	if (np->repflow)
>> +		np->flow_label = ip6_flowlabel(ipv6_hdr(skb));
>>  	if (!want_cookie || tmp_opt.tstamp_ok)
>>  		TCP_ECN_create_request(req, skb, sock_net(sk));
>>  
> 
> I am not sure here, do you write the flow_label on the listening socket?
> 

Hum, yes. You are right, this is bad.

One alternative is not so simple. Perhaps could we store the flowlabel
in inet_request_sock? It will be available in the tcp_v6_send_synack
function, even in case of retransmission.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html