netdev - Re: [PATCH net-next] ipv4: fix a dst leak in tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140116.171303.2113967209121208034.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 17:13:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, maze@...gle.com,
	cwang@...pensource.com
Subject: Re: [PATCH net-next] ipv4: fix a dst leak in tunnels

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Jan 2014 16:41:19 -0800

> This patch :
> 
> 1) Remove a dst leak if DST_NOCACHE was set on dst
>    Fix this by holding a reference only if dst really cached.

Can you explain this problem a little bit more?

Why do we have to handle DST_NOCACHE specially?  We hold a reference
and dst_release() knows what to do with DST_NOCACHE routes.

Or is it semantically undesirable for tunnels to cache these routes?
If so, why do we leave sockets caching DST_NOCACHE routes just fine?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html