netdev - Re: [PATCH net-next 1/2] net: add NETDEV_PRECHANGEMTU to notify before mtu change happens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140116.171622.986681235335792902.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 17:16:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, edumazet@...gle.com,
	nicolas.dichtel@...nd.com, amwang@...hat.com
Subject: Re: [PATCH net-next 1/2] net: add NETDEV_PRECHANGEMTU to notify
 before mtu change happens

From: Veaceslav Falico <vfalico@...hat.com>
Date: Thu, 16 Jan 2014 00:02:18 +0100

> Currently, if a device changes its mtu, first the change happens (invloving
> all the side effects), and after that the NETDEV_CHANGEMTU is sent so that
> other devices can catch up with the new mtu. However, if they return
> NOTIFY_BAD, then the change is reverted and error returned.
> 
> This is a really long and costy operation (sometimes). To fix this, add
> NETDEV_PRECHANGEMTU notification which is called prior to any change
> actually happening, and if any callee returns NOTIFY_BAD - the change is
> aborted. This way we're skipping all the playing with apply/revert the mtu.
> 
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Jiri Pirko <jiri@...nulli.us>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> CC: Cong Wang <amwang@...hat.com>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html