netdev - Re: [PATCH net-next v2 2/2] bonding: try to enable SG features when adding a new, slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140116.160721.427996343348396551.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 16:07:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, edumazet@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] bonding: try to enable SG features
 when adding a new, slave

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Tue, 14 Jan 2014 17:00:35 +0800

> The commit b0ce3508(bonding: allow TSO being set on bonding master)
> has make the TSO being set for bond dev, but in some situation, if
> the slave did not set the NETIF_F_SG features yet, the bond master
> will miss the TSO features in netdev_fix_features because the TSO is
> depended on SG.
> 
> If the slave hw support SG features, but not set yet, I will try to
> open it when enslave the dev, better for performance.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

I really don't think we should force enable device features in slaves
that perhaps the user intentionally disabled, or perhaps the driver has
a reason to disable by default (lower performance, etc.)

I'm not applying this series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html