[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1389923407-26969-1-git-send-email-ying.xue@windriver.com>
Date: Fri, 17 Jan 2014 09:50:02 +0800
From: Ying Xue <ying.xue@...driver.com>
To: <davem@...emloft.net>
CC: <Paul.Gortmaker@...driver.com>, <maloy@...jonn.com>,
<jon.maloy@...csson.com>, <erik.hugne@...csson.com>,
<netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>
Subject: [PATCH net-next 0/5] tipc: align TIPC behaviours of waiting for events with other stacks
Comparing the current implementations of waiting for events in TIPC
socket layer with other stacks, TIPC's behaviour is very different
because wait_event_interruptible_timeout()/wait_event_interruptible()
are always used by TIPC to wait for events while relevant socket or
port variables are fed to them as their arguments. As socket lock has
to be released temporarily before the two routines of waiting for
events are called, their arguments associated with socket or port
structures are out of socket lock protection. This might cause
serious issues where the process of calling socket syscall such as
sendsmg(), connect(), accept(), and recvmsg(), cannot be waken up
at all even if proper event arrives or improperly be woken up
although the condition of waking up the process is not satisfied
in practice.
Therefore, aligning its behaviours with similar functions implemented
in other stacks, for instance, sk_stream_wait_connect() and
inet_csk_wait_for_connect() etc, can avoid above risks for us.
Ying Xue (5):
tipc: standardize connect routine
tipc: standardize accept routine
tipc: standardize sendmsg routine of connectionless socket
tipc: standardize sendmsg routine of connected socket
tipc: standardize recvmsg routine
net/tipc/socket.c | 296 +++++++++++++++++++++++++++++++++--------------------
1 file changed, 186 insertions(+), 110 deletions(-)
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists