netdev - RE: [PATCH net-next 0/5] tipc: align TIPC behaviours of waiting for events with other stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Jan 2014 03:20:33 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	David Miller <davem@...emloft.net>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>
CC:	"Paul.Gortmaker@...driver.com" <Paul.Gortmaker@...driver.com>,
	"maloy@...jonn.com" <maloy@...jonn.com>,
	Erik Hugne <erik.hugne@...csson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next 0/5] tipc: align TIPC behaviours of waiting for
 events with other stacks

Nice job, Ying.
///jon

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: January-16-14 10:12 PM
> To: ying.xue@...driver.com
> Cc: Paul.Gortmaker@...driver.com; maloy@...jonn.com; Jon Maloy; Erik
> Hugne; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net
> Subject: Re: [PATCH net-next 0/5] tipc: align TIPC behaviours of waiting for
> events with other stacks
> 
> From: Ying Xue <ying.xue@...driver.com>
> Date: Fri, 17 Jan 2014 09:50:02 +0800
> 
> > Comparing the current implementations of waiting for events in TIPC
> > socket layer with other stacks, TIPC's behaviour is very different
> > because wait_event_interruptible_timeout()/wait_event_interruptible()
> > are always used by TIPC to wait for events while relevant socket or
> > port variables are fed to them as their arguments. As socket lock has
> > to be released temporarily before the two routines of waiting for
> > events are called, their arguments associated with socket or port
> > structures are out of socket lock protection. This might cause serious
> > issues where the process of calling socket syscall such as sendsmg(),
> > connect(), accept(), and recvmsg(), cannot be waken up at all even if
> > proper event arrives or improperly be woken up although the condition
> > of waking up the process is not satisfied in practice.
> >
> > Therefore, aligning its behaviours with similar functions implemented
> > in other stacks, for instance, sk_stream_wait_connect() and
> > inet_csk_wait_for_connect() etc, can avoid above risks for us.
> 
> Series applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html