netdev - Re: [RFC PATCH] tuntap: Fix for a race in accessing numqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52DABD35.3030408@cogentembedded.com>
Date:	Sat, 18 Jan 2014 21:43:17 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dominic Curran <dominic.curran@...rix.com>, netdev@...r.kernel.org
CC:	Jason Wang <jasowang@...hat.com>,
	Maxim Krasnyansky <maxk@...lcomm.com>
Subject: Re: [RFC PATCH] tuntap: Fix for a race in accessing numqueue

Hello.

On 18-01-2014 4:26, Dominic Curran wrote:

> A patch for fixing a race between queue selection and changing queues
> was introduced in commit 92bb73ea2c434618a68a5.

    Please also specify that commit's summary line in parens.

> The fix was to prevent the driver from re-reading the tun->numqueues
> more than once within tun_select_queue().

> We have been experiancing  'Divide-by-zero' errors in
> tun_net_xmit() since we moved from 3.6 to 3.10, and believe that they
> come from a simular source where the value of tun->numqueues changes
> to zero between the first and second read of tun->numqueues.

> Signed-off-by: Dominic Curran <dominic.curran@...rix.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Maxim Krasnyansky <maxk@...lcomm.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html