netdev - Re: [ PATCH net-next] qlcnic: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140118.230924.161581406065831782.davem@davemloft.net>
Date:	Sat, 18 Jan 2014 23:09:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	netdev@...r.kernel.org
Subject: Re: [ PATCH net-next] qlcnic: fix sparse warnings

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Sat, 18 Jan 2014 17:21:13 -0800

> From: Fengguang Wu <fengguang.wu@...el.com>
> 
> Previous patch changed prototypes, but forgot functions.
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> Acked-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> ---
>  qlcnic_83xx_hw.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c	2014-01-18 13:41:07.000000000 -0800
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c	2014-01-18 17:13:08.640658697 -0800
> @@ -2066,7 +2066,7 @@ void qlcnic_83xx_change_l2_filter(struct
>  	qlcnic_83xx_sre_macaddr_change(adapter, mac, vlan_id, QLCNIC_MAC_ADD);
>  }
>  
> -void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac,
> +static void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac,
>  			       u8 type, struct qlcnic_cmd_args *cmd)

Please adjust argument indentation, this goes for the whole patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html