netdev - Re: [PATCH] net: Correctly sync addresses from multiple sources to single device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52DFE425.2090404@redhat.com>
Date:	Wed, 22 Jan 2014 10:30:45 -0500
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, andrey.dmitrov@...etlabs.ru
Subject: Re: [PATCH] net: Correctly sync addresses from multiple sources to
 single device

On 01/21/2014 05:53 PM, David Miller wrote:
> From: Vlad Yasevich <vyasevic@...hat.com>
> Date: Fri, 17 Jan 2014 14:52:12 -0500
> 
>> When we have multiple devices attempting to sync the same address
>> to a single destination, each device should be permitted to sync
>> it once.  To accomplish this, pass the sync count of the source
>> address to __hw_addr_add_ex().  'sync_cnt' tracks how many time
>> a given address has been successfully synced.  If the address
>> is found in the destination list, but the 'sync_cnt' of the source
>> is 0, then this address has not been synced from this interface
>> and we need to allow the sync operation to succeed thus incrementing
>> reference counts.
>>
>> Reported-by: Andrey Dmitrov <andrey.dmitrov@...etlabs.ru>
>> CC: Andrey Dmitrov <andrey.dmitrov@...etlabs.ru>
>> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> 
> I applied this to net-next since 3.13 just got released, and it doesn't
> compile.
> 
> net/core/dev_addr_lists.c: In function ‘__hw_addr_sync_one’:
> net/core/dev_addr_lists.c:144:26: error: ‘struct netdev_hw_addr’ has no member named ‘sync_count’
> 

That does it...  Time to add a hook to format_patch to check for dirty
index.

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html