netdev - Re: [PATCH net-next] net: phy: use network device in phy_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcaDTOxBHNgSF1wme8JgnYV-KjpNfqqcNLdebqR0hjnWJg@mail.gmail.com>
Date:	Wed, 22 Jan 2014 10:52:09 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: phy: use network device in phy_print_status

2014/1/22 Joe Perches <joe@...ches.com>:
> On Wed, 2014-01-22 at 10:32 -0800, Florian Fainelli wrote:
>> phy_print_status() currently uses dev_name(&phydev->dev) which will
>> usually result in printing something along those lines for Device Tree
>> aware drivers:
>>
>> libphy: f0b60000.etherne:0a - Link is Down
>> libphy: f0ba0000.etherne:00 - Link is Up - 1000/Full
>>
>> This is not terribly useful for network administrators or users since we
>> expect a network interface name to be able to correlate link events with
>> interfaces. Update phy_print_status() to use netdev_info() with
>> phydev->attached_dev which is the backing network device for our PHY
>> device.
> []
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> []
>> @@ -45,12 +45,11 @@
>>  void phy_print_status(struct phy_device *phydev)
>>  {
>>       if (phydev->link) {
>> -             pr_info("%s - Link is Up - %d/%s\n",
>> -                     dev_name(&phydev->dev),
>> +             netdev_info(phydev->attached_dev, "- Link is Up - %d/%s\n",
>>                       phydev->speed,
>>                       DUPLEX_FULL == phydev->duplex ? "Full" : "Half");
>>       } else  {
>> -             pr_info("%s - Link is Down\n", dev_name(&phydev->dev));
>> +             netdev_info(phydev->attached_dev, "- Link is Down\n");
>>       }
>
> The leading "- "'s now aren't useful and these could be

I did not want to remove the leading "- " since this would sort of
produce a very different message now, that said, I have no strong
feeling removing it.

>
>         if (phydev->link)
>                 netdev_info(phydev->attached_dev, "Link is Up - %d/%s\n",
>                             phydev->speed,
>                             phydev->duplex == DUPLEX_FULL ? "Full" : "Half");
>         else
>                 netdev_info(phydev->attached_dev, "Link is Down\n");
>
> Is is possible that phydev->attached_dev is NULL?

Not when this is called, it is safe to use phydev->attached_dev.

>
> It may also be possible to slightly improve the output by
> reducing the number of 0's in the speed block and emitting
> Kb/Mb/Gb (or Kbps/Mbps/Gbps) and maybe flow control if it's
> available.

Sure thing, that calls for a follow-up patch though.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html