netdev - Re: [net-next PATCH 1/1] drivers: net: cpsw: enable promiscuous mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140121.181137.840971123475894969.davem@davemloft.net>
Date:	Tue, 21 Jan 2014 18:11:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mugunthanvnm@...com
Cc:	netdev@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: enable promiscuous
 mode support

From: Mugunthan V N <mugunthanvnm@...com>
Date: Mon, 20 Jan 2014 17:38:38 +0530

> +		if (!enable && ((priv->slaves[0].ndev->flags & IFF_PROMISC) ||
> +				(priv->slaves[1].ndev->flags & IFF_PROMISC))) {

This assumption that there are exactly 2 slaves is not valid.

Use the appropriate for_each_slave() et al. abstractions to access
the slaves.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html