netdev - Re: [PATCH net-next 0/7] sctp: remove some macro locking wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140121.184229.116401257671728929.davem@davemloft.net>
Date:	Tue, 21 Jan 2014 18:42:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	wangweidong1@...wei.com, nhorman@...driver.com,
	dborkman@...hat.com, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] sctp: remove some macro locking wrappers

From: Vlad Yasevich <vyasevich@...il.com>
Date: Tue, 21 Jan 2014 10:16:09 -0500

> On 01/21/2014 02:44 AM, Wang Weidong wrote:
>> In sctp.h we can find some macro locking wrappers. As Neil point out that:
>> 
>> "Its because in the origional implementation of the sctp protocol, there was a
>> user space test harness which built the kernel module for userspace execution to
>> cary our some unit testing on the code.  It did so by redefining some of those
>> locking macros to user space friendly code.  IIRC we haven't use those unit
>> tests in years, and so should be removing them, not adding them to other
>> locations."
>> 
>> So I remove them.
>> 
>> Wang Weidong (7):
>>   sctp: remove macro sctp_spin_[un]lock_irqrestore
>>   sctp: remove macro sctp_local_bh_{disable|enable}
>>   sctp: remove macro sctp_spin_[un]lock
>>   sctp: remove macros sctp_write_[un]_lock
>>   sctp: remove macros sctp_read_[un]lock
>>   sctp: remove macros sctp_{lock|release}_sock
>>   sctp: remove macros sctp_bh_[un]lock_sock
>> 
>>  include/net/sctp/sctp.h  | 27 ++-----------
>>  net/sctp/endpointola.c   |  4 +-
>>  net/sctp/input.c         | 54 +++++++++++++-------------
>>  net/sctp/proc.c          | 12 +++---
>>  net/sctp/protocol.c      |  4 +-
>>  net/sctp/sm_sideeffect.c | 16 ++++----
>>  net/sctp/socket.c        | 98 ++++++++++++++++++++++++------------------------
>>  7 files changed, 98 insertions(+), 117 deletions(-)
>> 
> 
> I like this series just the way it is.  Very simple to review.
> 
> Series
> Acked-by: Vlad Yasevich <vyasevich@...il.com>

I had to append the DLM fix (since it used the sctp_*() interfaces) to
patch #6, otherwise it would have broken bisection.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html