| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1390360813-29185-2-git-send-email-chris.ruehl@gtsys.com.hk> Date: Wed, 22 Jan 2014 11:20:13 +0800 From: Chris Ruehl <chris.ruehl@...ys.com.hk> To: netdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org, davem@...emloft.net, Chris Ruehl <chris.ruehl@...ys.com.hk> Subject: [PATCH 2/2] net: dm9000: Only call PHY reset for TYPE-B on shutdown Unconditional call of PHY reset can triggers a fault to detect the link for DM9000A on reboot, only a hard reset can solve it. This patch check the version of the chip and call the PHY reset only for the B version of the chip. Signed-off-by: Chris Ruehl <chris.ruehl@...ys.com.hk> --- drivers/net/ethernet/davicom/dm9000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 0349b91..55a2e9c 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -1333,7 +1333,8 @@ dm9000_shutdown(struct net_device *dev) board_info_t *db = netdev_priv(dev); /* RESET device */ - dm9000_phy_write(dev, 0, MII_BMCR, BMCR_RESET); /* PHY RESET */ + if (db->type == TYPE_DM9000B) + dm9000_phy_write(dev, 0, MII_BMCR, BMCR_RESET); /* PHY RESET */ iow(db, DM9000_GPR, 0x01); /* Power-Down PHY */ iow(db, DM9000_IMR, IMR_PAR); /* Disable all interrupt */ iow(db, DM9000_RCR, 0x00); /* Disable RX */ -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists