netdev - Re: [PATCH] bonding: Don't allow bond devices to change network namespaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140122094106.GB2814@minipsycho.orion>
Date:	Wed, 22 Jan 2014 10:41:06 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Chen Weilong <chenweilong@...wei.com>
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: Don't allow bond devices to change network
 namespaces.

Wed, Jan 22, 2014 at 10:16:30AM CET, chenweilong@...wei.com wrote:
>From: Weilong Chen <chenweilong@...wei.com>
>
>Like bridge, bonding as netdevice doesn't cross netns boundaries.
>
>Bonding ports and bonding itself live in same netns.

I think should should be done for team as well. Openvs already
has this. I believe that for vlans it is ok to change ns, right?

>
>Signed-off-by: Weilong Chen <chenweilong@...wei.com>
>---
> drivers/net/bonding/bond_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index f00dd45..897d153 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -3916,6 +3916,9 @@ void bond_setup(struct net_device *bond_dev)
> 	 * capable
> 	 */
> 
>+	/* Don't allow bond devices to change network namespaces. */
>+	bond_dev->features |= NETIF_F_NETNS_LOCAL;
>+
> 	bond_dev->hw_features = BOND_VLAN_FEATURES |
> 				NETIF_F_HW_VLAN_CTAG_TX |
> 				NETIF_F_HW_VLAN_CTAG_RX |
>-- 
>1.7.12
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html