netdev - Re: [PATCH net-next 1/3] sch_netem: return errcode before setting params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140123092503.1a7811ef@nehalam.linuxnetplumber.net>
Date:	Thu, 23 Jan 2014 09:25:03 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/3] sch_netem: return errcode before setting
 params

I am not sure how important it is that netem updates to multiple
parameters act as a single transaction. The only failures possible
are out of memory and user configuration error.

I prefer the simplicity of the original code.


> +			/* recover clg and loss_model, in case of
> +			 * q->clg and q->loss_model were modified
> +			 * in get_loss_clg() */

This comment needs to be formatted as:
	/* multiline comment
         * example
         */


 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html