netdev - Re: [PATCH net-next v2] tcp: metrics: Handle v6/v4-mapped sockets in tcp-metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140123.124926.313254281273203545.davem@davemloft.net>
Date:	Thu, 23 Jan 2014 12:49:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tcp: metrics: Handle v6/v4-mapped sockets
 in tcp-metrics

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Wed, 22 Jan 2014 13:58:44 +0100

> A socket may be v6/v4-mapped. In that case sk->sk_family is AF_INET6,
> but the IP being used is actually an IPv4-address.
> Current's tcp-metrics will thus represent it as an IPv6-address:
> 
> root@...ver:~# ip tcp_metrics
> ::ffff:10.1.1.2 age 22.920sec rtt 18750us rttvar 15000us cwnd 10
> 10.1.1.2 age 47.970sec rtt 16250us rttvar 10000us cwnd 10
> 
> This patch modifies the tcp-metrics so that they are able to handle the
> v6/v4-mapped sockets correctly.
> 
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>

Applied, but I guess you didn't look at the build warnings, nor thoroughly
test this:

> +	else if (sk->sk_family = AF_INET6) {

That's an assignment, not a straight test, and the compiler warns
about it.

I fixed it when I applied this, but please don't be so sloppy in the
future.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html