netdev - Re: [PATCH v2] net: Correctly sync addresses from multiple sources to single device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140123.130720.1596532534979092173.davem@davemloft.net>
Date:	Thu, 23 Jan 2014 13:07:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org, andrey.dmitrov@...etlabs.ru,
	Alexandra.Kossovsky@...etlabs.ru, Konstantin.Ushakov@...etlabs.ru
Subject: Re: [PATCH v2] net: Correctly sync addresses from multiple sources
 to single device

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Wed, 22 Jan 2014 12:54:15 -0500

> When we have multiple devices attempting to sync the same address
> to a single destination, each device should be permitted to sync
> it once.  To accomplish this, pass the 'sync_cnt' of the source
> address when adding the addresss to the lower device.  'sync_cnt'
> tracks how many time a given address has been succefully synced.
> This way, we know that if the 'sync_cnt' passed in is 0, we should
> sync this address.
> 
> Also, turn 'synced' member back into the counter as was originally
> done in
>    commit 4543fbefe6e06a9e40d9f2b28d688393a299f079.
>    net: count hw_addr syncs so that unsync works properly.
> It tracks how many time a given address has been added via a
> 'sync' operation.  For every successfull 'sync' the counter is
> incremented, and for ever 'unsync', the counter is decremented.
> This makes sure that the address will be properly removed from
> the the lower device when all the upper devices have removed it.
> 
> Reported-by: Andrey Dmitrov <andrey.dmitrov@...etlabs.ru>
> CC: Andrey Dmitrov <andrey.dmitrov@...etlabs.ru>
> CC: Alexandra N. Kossovsky <Alexandra.Kossovsky@...etlabs.ru>
> CC: Konstantin Ushakov <Konstantin.Ushakov@...etlabs.ru>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

This one compiles, great :-)

Applied, thanks Vlad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html