lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jan 2014 02:25:28 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Zoltan Kiss <zoltan.kiss@...rix.com>, Jay Vosburgh <fubar@...ibm.com>, Veaceslav Falico <vfalico@...hat.com>, Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Nikolay Aleksandrov <nikolay@...hat.com> Subject: Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers Hello. On 23-01-2014 22:47, Zoltan Kiss wrote: > Nikolay Aleksandrov's recent bonding option API changes (25a9b54a and e4994612) You should also specify those commits' summary lines. > introduced u64 as the type of downdelay and updelay. On 32 bit the division and > modulo operations cause compile errors: > ERROR: "__udivdi3" [drivers/net/bonding/bonding.ko] undefined! > ERROR: "__umoddi3" [drivers/net/bonding/bonding.ko] undefined! > This patch use the do_div macro, which guaranteed to do the right thing. > Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com> > --- > drivers/net/bonding/bond_options.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c > index 4cee04a..4f94907 100644 > --- a/drivers/net/bonding/bond_options.c > +++ b/drivers/net/bonding/bond_options.c [...] > @@ -727,19 +728,20 @@ int bond_option_miimon_set(struct bonding *bond, struct bond_opt_value *newval) > > int bond_option_updelay_set(struct bonding *bond, struct bond_opt_value *newval) > { > + u64 quotient = newval->value; > + u64 remainder = do_div(quotient, bond->params.miimon); Empty line after declarations wouldn't hurt here. > @@ -750,19 +752,20 @@ int bond_option_updelay_set(struct bonding *bond, struct bond_opt_value *newval) > int bond_option_downdelay_set(struct bonding *bond, > struct bond_opt_value *newval) > { > + u64 quotient = newval->value; > + u64 remainder = do_div(quotient, bond->params.miimon); And here. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists