netdev - Re: [PATCH net-next v2 4/4] net: phy: remove unneeded parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jan 2014 02:37:30 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, joe@...ches.com
Subject: Re: [PATCH net-next v2 4/4] net: phy: remove unneeded parenthesis

Hello.

On 24-01-2014 0:17, Florian Fainelli wrote:

> Our if/else statement in phy_print_status() is only comprised of one
> line for each, remove the parenthesis.

    I protest, the *if* arm is multi-line, though single statement. :-)
Could we avoid changing that code to and fro during 3.14-rc1?

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>   drivers/net/phy/phy.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 36fc6e1..59aa85e 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -64,15 +64,14 @@ static const char *phy_speed_to_str(int speed)
>    */
>   void phy_print_status(struct phy_device *phydev)
>   {
> -	if (phydev->link) {
> +	if (phydev->link)
>   		netdev_info(phydev->attached_dev,
>   			"Link is Up - %s/%s - flow control %s\n",
>   			phy_speed_to_str(phydev->speed),
>   			DUPLEX_FULL == phydev->duplex ? "Full" : "Half",
>   			phydev->pause ? "rx/tx" : "off");
> -	} else	{
> +	else
>   		netdev_info(phydev->attached_dev, "Link is Down\n");
> -	}
>   }
>   EXPORT_SYMBOL(phy_print_status);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html