netdev - Re: [[Xen-devel] [PATCH net-next v3] xen-netfront: clean up code in xennet_release_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52E0F528.7060302@citrix.com>
Date:	Thu, 23 Jan 2014 10:55:36 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Annie Li <Annie.li@...cle.com>
CC:	<xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>,
	<konrad.wilk@...cle.com>, <ian.campbell@...rix.com>,
	<wei.liu2@...rix.com>
Subject: Re: [[Xen-devel] [PATCH net-next v3] xen-netfront: clean up code
 in xennet_release_rx_bufs

On 23/01/14 01:36, Annie Li wrote:
> From: Annie Li <annie.li@...cle.com>
> 
> This patch removes grant transfer code from netfront, and improves ending
> grant acess mechanism since gnttab_end_foreign_access_ref may fail when
> the grant entry is currently used for reading or writing.
> 
> * release grant reference and skb for tx/rx path, use get_page/put_page to
> ensure page is released when grant access is completed successfully.
> * change corresponding code in xen-blkfront/xen-tpmfront/xen-pcifront because
> of code change for put_page in gnttab_end_foreign_access.
> * clean up grant transfer code kept from old netfront(2.6.18) which grants
> pages for access/map and transfer. But grant transfer is deprecated in current
> netfront, so remove corresponding release code for transfer.
> 
> V3: Changes as suggestion from David Vrabel, ensure pages are not freed untill
> grant acess is ended.
> 
> V2: improve patch comments.
> Signed-off-by: Annie Li <annie.li@...cle.com>
> ---
>  drivers/block/xen-blkfront.c    |   25 ++++++++---
>  drivers/char/tpm/xen-tpmfront.c |    7 +++-
>  drivers/net/xen-netfront.c      |   93 ++++++++++++--------------------------
>  drivers/pci/xen-pcifront.c      |    7 +++-
>  drivers/xen/grant-table.c       |    4 +-
>  5 files changed, 63 insertions(+), 73 deletions(-)

I don't understand why you've made all these unnecessary changes to the
other frontends and grant-table.c.

The xen-netfront.c changes are fine on their own.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html