netdev - Re: [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init() into tcf_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV2zKF3vQGmsa0Fvcii2+tQTKmp=6a-odggbFnJK8snjQ@mail.gmail.com>
Date:	Thu, 23 Jan 2014 16:52:00 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init()
 into tcf_register_action()

On Thu, Jan 23, 2014 at 4:08 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Thu, 23 Jan 2014 14:35:23 -0800
> Cong Wang <xiyou.wangcong@...il.com> wrote:
>
>>
>>  struct tc_action {
>>       void                    *priv;
>> -     const struct tc_action_ops      *ops;
>> +     struct tc_action_ops    *ops;
>
> As much as possible all function tables should be constant.
> One of the rootkit tricks is to overwrite a function table entry
> at runtime. Granted tc action is a minor corner of the exposed
> universe, but this seems a step backwards when the only real
> gain is some refactoring/cleanup.

Yeah, then we can keep hinfo as a pointer in ops,
and allocate it dynamically.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html