lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jan 2014 19:05:26 +0800 From: annie li <annie.li@...cle.com> To: David Vrabel <david.vrabel@...rix.com> CC: netdev@...r.kernel.org, wei.liu2@...rix.com, ian.campbell@...rix.com, xen-devel@...ts.xen.org Subject: Re: [Xen-devel] [PATCH net-next v4] xen-netfront: clean up code in xennet_release_rx_bufs On 2014/1/24 18:48, David Vrabel wrote: > On 24/01/14 03:28, Annie Li wrote: >> From: Annie Li <annie.li@...cle.com> >> >> This patch removes grant transfer releasing code from netfront, and uses >> gnttab_end_foreign_access to end grant access since >> gnttab_end_foreign_access_ref may fail when the grant entry is >> currently used for reading or writing. >> >> * clean up grant transfer code kept from old netfront(2.6.18) which grants >> pages for access/map and transfer. But grant transfer is deprecated in current >> netfront, so remove corresponding release code for transfer. >> >> * release grant access (through gnttab_end_foreign_access) and skb for tx/rx path, >> use get_page to ensure page is released when grant access is completed successfully. >> >> Xen-blkfront/xen-tpmfront/xen-pcifront also have similar issue, but patches >> for them will be created separately. > ... >> @@ -1439,8 +1403,11 @@ static int netfront_probe(struct xenbus_device *dev, >> static void xennet_end_access(int ref, void *page) >> { >> /* This frees the page as a side-effect */ >> - if (ref != GRANT_INVALID_REF) >> + if (ref != GRANT_INVALID_REF) { >> + get_page(virt_to_page(page)); >> gnttab_end_foreign_access(ref, 0, (unsigned long)page); >> + free_page((unsigned long)page); >> + } >> } Oh, these code were kept from my debug, will remove it. Thanks Annie > Please drop this hunk. > > Otherwise, > > Reviewed-by: David Vrabel <david.vrabel@...rix.com> > > David > > _______________________________________________ > Xen-devel mailing list > Xen-devel@...ts.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists