lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jan 2014 18:27:36 +0000 From: Zoltan Kiss <zoltan.kiss@...rix.com> To: Nikolay Aleksandrov <nikolay@...hat.com>, Jay Vosburgh <fubar@...ibm.com>, Veaceslav Falico <vfalico@...hat.com>, Andy Gospodarek <andy@...yhouse.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers On 23/01/14 21:18, Nikolay Aleksandrov wrote: >> Hi Zoltan, >> Thanks for fixing this, a few comments though: >> bond->params.miimon can be 0 here that's why there's a check afterwards, >> also please separate the local variable definitions from the body with a >> new line. >> The same applies for downdelay. >> >> Nik > In fact since we don't need the u64 and newval->value is limited to > INT_MAX, can't we simply cast it to (int) and avoid the do_div entirely ? Yep, that's even better, thanks for fixing it! Zoli -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists