lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Jan 2014 10:19:48 +0100 From: Florian Westphal <fw@...len.de> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Florian Westphal <fw@...len.de>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] net: add and use skb_gso_transport_seglen() Eric Dumazet <eric.dumazet@...il.com> wrote: > On Sat, 2014-01-25 at 23:48 +0100, Florian Westphal wrote: > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -45,6 +45,7 @@ > > #include <linux/mm.h> > > #include <linux/interrupt.h> > > #include <linux/in.h> > > +#include <linux/tcp.h> > > #include <linux/inet.h> > > #include <linux/slab.h> > > #include <linux/netdevice.h> > > @@ -71,6 +72,8 @@ > > #include <trace/events/skb.h> > > #include <linux/highmem.h> > > > > +#include <uapi/linux/udp.h> > > > Normally you should not use uapi/ I added this include to ensure sizeof(struct udphdr) works. I'll change it to linux/udp.h > > diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c > > index 887e672..837a61b 100644 > > --- a/net/sched/sch_tbf.c > > +++ b/net/sched/sch_tbf.c > > It seems you forgot to remove from this file this include : > > #include <net/tcp.h> Indeed, thanks for spotting this. > Otherwise, this seems good, thanks ! Thanks for reviewing Eric! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists