netdev - Re: [PATCH] xfrm: fix potential incorrect pointer dereference in xfrm_bundle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140125.180534.939675200515296620.davem@davemloft.net>
Date:	Sat, 25 Jan 2014 18:05:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	horia.geanta@...escale.com, steffen.klassert@...unet.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: fix potential incorrect pointer dereference in
 xfrm_bundle_create

From: Joe Perches <joe@...ches.com>
Date: Sat, 25 Jan 2014 11:32:58 -0800

> Yes, but perhaps the failure test be done before the
> assignment anyway.  There are more paths below the test
> where the value is not yet used.

And because we have no uses, there is no harm in the assignment.

> Perhaps something like this would be more readable.

That's a lot of useless churn if you ask me.

If we happen to be making other changes to this file, fine.
But there are much bigger fish to fry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html