lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jan 2014 17:40:56 +0800 From: Jason Wang <jasowang@...hat.com> To: David Miller <davem@...emloft.net> CC: kys@...rosoft.com, haiyangz@...rosoft.com, devel@...uxdriverproject.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] net: hyperv: initialize link status correctly On 01/27/2014 04:35 PM, David Miller wrote: > From: Jason Wang <jasowang@...hat.com> > Date: Mon, 27 Jan 2014 15:30:54 +0800 > >> Call netif_carrier_on() after register_device(). Otherwise it won't work since >> the device was still in NETREG_UNINITIALIZED state. >> >> Fixes a68f9614614749727286f675d15f1e09d13cb54a >> (hyperv: Fix race between probe and open calls) >> >> Cc: Haiyang Zhang <haiyangz@...rosoft.com> >> Cc: K. Y. Srinivasan <kys@...rosoft.com> >> Reported-by: Di Nie <dnie@...hat.com> >> Tested-by: Di Nie <dnie@...hat.com> >> Signed-off-by: Jason Wang <jasowang@...hat.com> > A device up can occur at the moment you call register_netdevice(), > therefore that up call can see the carrier as down and fail or > similar. So you really cannot resolve the carrier to be on in this > way. True, we need a workqueue to synchronize them. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists