lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jan 2014 06:49:04 -0500 From: Neil Horman <nhorman@...driver.com> To: Wang Weidong <wangweidong1@...wei.com> Cc: davem@...emloft.net, vyasevich@...il.com, dborkman@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH 0/2] sctp: fix a problem with net_namespace On Mon, Jan 27, 2014 at 11:49:01AM +0800, Wang Weidong wrote: > fix a problem with net_namespace, and optimize > the sctp_sysctl_net_register. > > Wang Weidong (2): > sctp: fix a missed .data initialization > sctp: optimize the sctp_sysctl_net_register > > net/sctp/sysctl.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > -- > 1.7.12 > > > I don't see that either of these patches are needed. In sctp_init_net, the sctp_hmac_alg pointer gets initalized before calling sctp_sysctl_net_register, and sctp_proc_do_hmac_alg is written to specifically expect NULL values, so this code may change behavior regarding default cookie selection. This was coded so that poniters to entires in the string table could be used, rather than needing to allocate or maintain character buffers. That said, it does look like that for loop in sctp_sysctl_register_table might compute an odd offset when cloning the table. I think the right fix for that is likely to just move the sysctl value initalization in sctp_init_net to below the sysctl register function. Neil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists