lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jan 2014 11:45:45 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Max Filippov <jcmvbkbc@...il.com> Cc: Rob Herring <robherring2@...il.com>, "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>, netdev <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Chris Zankel <chris@...kel.net>, Marc Gauthier <marc@...ence.com>, "David S. Miller" <davem@...emloft.net>, Grant Likely <grant.likely@...aro.org>, Rob Herring <rob.herring@...xeda.com> Subject: Re: [PATCH 3/3] net: ethoc: document OF bindings 2014-01-27 Max Filippov <jcmvbkbc@...il.com>: > Hi Rob, > > On Mon, Jan 27, 2014 at 6:10 PM, Rob Herring <robherring2@...il.com> wrote: >> On Sun, Jan 26, 2014 at 9:59 PM, Max Filippov <jcmvbkbc@...il.com> wrote: >>> Signed-off-by: Max Filippov <jcmvbkbc@...il.com> >>> --- >>> .../devicetree/bindings/net/opencores-ethoc.txt | 25 ++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/opencores-ethoc.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/opencores-ethoc.txt b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >>> new file mode 100644 >>> index 0000000..f7c6c94 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >>> @@ -0,0 +1,25 @@ >>> +* OpenCores MAC 10/100 Mbps >>> + >>> +Required properties: >>> +- compatible: Should be "opencores,ethoc". >> >> There are not different versions of IP or is the version probeable? > > AFAIK there's single version of this 10/100 MAC. > It doesn't have any identification registers. Since this is an IP block that people can modify due to its open source nature, it would have been good to define a revision register or such which would allow software to gate specific code based on that revision. > >>> +- reg: Address and length of the register set for the device and of its >>> + descriptor memory. >>> +- interrupts: Should contain ethoc interrupt. >>> + >>> +Optional properties: >>> +- local-mac-address: 6 bytes, mac address >> >> There's a patch in progress to move all the standard network >> properties to a common location, so you can remove this. > > Will do. > >>> +- clock-frequency: basic MAC frequency. >>> +- mii-mgmt-clock-frequency: frequency of MII management bus. Together >>> + with clock-frequency determines the value programmed into the CLKDIV >>> + field of MIIMODER register. >>> + >>> +Examples: >>> + >>> + enet0: ethoc@...30000 { >>> + compatible = "opencores,ethoc"; >>> + reg = <0xfd030000 0x4000 0xfd800000 0x4000>; >>> + interrupts = <1>; >>> + local-mac-address = [00 50 c2 13 6f 00]; >>> + clock-frequency = <50000000>; >>> + mii-mgmt-clock-frequency = <5000000>; 5Mhz management clock? Can't you make it work with the standard 2.5Mhz management clock? Is not there a risk not to be able to "talk" to some PHY chips out there which do not support > 2.5Mhz management clock? Since this is an ethoc specific property, should it be prefixed with "ethoc,"? -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists