netdev - Re: [PATCH] sky2: initialize napi before registering device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140127.164022.1770189430751977967.davem@davemloft.net>
Date:	Mon, 27 Jan 2014 16:40:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	stf_xl@...pl
Cc:	netdev@...r.kernel.org, mlindner@...vell.com,
	stephen@...workplumber.org
Subject: Re: [PATCH] sky2: initialize napi before registering device

From: Stanislaw Gruszka <stf_xl@...pl>
Date: Sat, 25 Jan 2014 11:34:54 +0100

> There is race condition when call netif_napi_add() after
> register_netdevice(), as ->open() can be called without napi initialized
> and trigger BUG_ON() on napi_enable(), like on below messages:
...
> To fix the problem patch changes the order of initialization.
> 
> Bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=67151
> 
> Reported-and-tested-by: ebrahim.azarisooreh@...il.com
> Signed-off-by: Stanislaw Gruszka <stf_xl@...pl>

Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html