netdev - Re: [PATCH net-next] bonding: fix locking in bond_loadbalance_arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140128.234858.302883010176792367.davem@davemloft.net>
Date:	Tue, 28 Jan 2014 23:48:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, netdev@...r.kernel.org,
	andy@...yhouse.net
Subject: Re: [PATCH net-next] bonding: fix locking in
 bond_loadbalance_arp_mon()

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Tue, 28 Jan 2014 11:48:53 +0800

> The commit 1d3ee88ae0d605629bf369
> (bonding: add netlink attributes to slave link dev)
> has add rtmsg_ifinfo() in bond_set_active_slave() and
> bond_set_backup_slave(), so the two function need to
> called in RTNL lock, but bond_loadbalance_arp_mon()
> only calling these functions in RCU, warning message
> will occurs.
> 
> fix this by add a new function bond_slave_state_change(),
> which will reset the slave's state after slave link check,
> so remove the bond_set_xxx_slave() from the cycle and only
> record the slave_state_changed, this will call the new
> function to set all slaves to new state in RTNL later.
> 
> Cc: Jay Vosburgh <fubar@...ibm.com>
> Cc: Veaceslav Falico <vfalico@...hat.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html