lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jan 2014 15:42:48 +0100 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [Patch net] net: allow setting mac address of loopback device On Wed, Jan 29, 2014 at 03:38:51PM -0800, Cong Wang wrote: > We are trying to mirror the local traffic from lo to eth0, > allowing setting mac address of lo to eth0 would make > the ether addresses in these packets correct, so that > we don't have to modify the ether header again. > > Since usually no one cares about its mac address (all-zero), > it is safe to allow those who care to set its mac address. > > Cc: Stephen Hemminger <stephen@...workplumber.org> > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: David S. Miller <davem@...emloft.net> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> > > --- > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > index c5011e0..a0ee030 100644 > --- a/drivers/net/loopback.c > +++ b/drivers/net/loopback.c > @@ -160,6 +160,7 @@ static const struct net_device_ops loopback_ops = { > .ndo_init = loopback_dev_init, > .ndo_start_xmit= loopback_xmit, > .ndo_get_stats64 = loopback_get_stats64, > + .ndo_set_mac_address = eth_mac_addr, > }; IFF_LIVE_ADDR_CHANGE would also be helpful to change mac address if loopback is already up. Also I doubt this is a change for net but for net-next. Greetings, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists