| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jan 2014 09:24:05 +0100 From: Nicolas Dichtel <nicolas.dichtel@...nd.com> To: rostedt@...dmis.org Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, stable@...r.kernel.org, williams@...hat.com, lclaudio@...g.org, jkacur@...hat.com, willemb@...gle.com, Nicolas Dichtel <nicolas.dichtel@...nd.com> Subject: [PATCH linux-3.10.y v2 2/3] Revert "ip6tnl: fix use after free of fb_tnl_dev" This reverts commit 22c3ec552c29cf4bd4a75566088950fe57d860c4. This patch is not the right fix, it introduces a memory leak when a netns is destroyed (the FB device is never deleted). Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com> Reported-by: Steven Rostedt <srostedt@...hat.com> Tested-by: Steven Rostedt <srostedt@...hat.com> (and our entire MRG team) Tested-by: "Luis Claudio R. Goncalves" <lgoncalv@...hat.com> Tested-by: John Kacur <jkacur@...hat.com> --- v2: add Steven's tags net/ipv6/ip6_tunnel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 209bb4d6e188..0516ebbea80b 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -1711,6 +1711,8 @@ static void __net_exit ip6_tnl_destroy_tunnels(struct ip6_tnl_net *ip6n) } } + t = rtnl_dereference(ip6n->tnls_wc[0]); + unregister_netdevice_queue(t->dev, &list); unregister_netdevice_many(&list); } -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists