netdev - Re: [PATCH] staging: r8188eu: Fix typo in USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52EF1804.50804@lwfinger.net>
Date:	Sun, 02 Feb 2014 22:16:04 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	netdev@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

On 02/02/2014 03:26 PM, Greg KH wrote:
> On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
>> There is a typo in the device list that interchanges the vendor and
>> product codes for one of the entries.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>> ---
>>   drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> index 0a341d6..e9e3c76 100644
>> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
>>   	{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
>>   	/*=== Customer ID ===*/
>>   	/****** 8188EUS ********/
>> -	{USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
>> +	{USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
>
> Becides the b8 -> bb issue, are you sure this is correct?  I've seen
> lots of USB devices that got this backwards (vendor id in the product id
> place), so it wouldn't be the first time it's happened.

The listing at http://www.linux-usb.org/usb.ids shows that the vendor code for 
AboCom Systems Inc is 0x07b8. Although it does not show a device id of 0x8179, 
I'm pretty sure that this listing has reversed the two entries.

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html