netdev - Re: [PATCH] ip_tunnel: fix panic in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140203.130309.1340651554312620948.davem@davemloft.net>
Date:	Mon, 03 Feb 2014 13:03:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	tt.rantala@...il.com, netdev@...r.kernel.org, davej@...hat.com,
	trinity@...r.kernel.org, linux-kernel@...r.kernel.org,
	therbert@...gle.com, maze@...gle.com
Subject: Re: [PATCH] ip_tunnel: fix panic in ip_tunnel_xmit()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 03 Feb 2014 12:52:14 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Setting rt variable to NULL at the beginning of ip_tunnel_xmit()
> missed possible use of this variable as a scratch value.
> 
> Also fixes a possible dst leak in tunnel_dst_check() :
> If we had to call tunnel_dst_reset(), we forgot to
> release the reference on dst.
> 
> Merges tunnel_dst_get()/tunnel_dst_check() into
> a single tunnel_rtable_get() function for clarity.
> 
> Many thanks to Tommi for his report and tests.
> 
> Fixes: 7d442fab0a67 ("ipv4: Cache dst in tunnels)"
> Reported-by: Tommi Rantala <tt.rantala@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Tommi Rantala <tt.rantala@...il.com>
> Cc: Tom Herbert <therbert@...gle.com>
> Cc: Maciej Żenczykowski <maze@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html