lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Feb 2014 08:20:08 +0100 From: Richard Cochran <richardcochran@...il.com> To: Stefan Sørensen <stefan.sorensen@...ctralink.com> Cc: netdev@...r.kernel.org Subject: Re: [PATCH v2] ptp: Allow selecting trigger/event index in testptp Sorry to be so picky, but... On Tue, Feb 04, 2014 at 07:25:06AM +0100, Stefan Sørensen wrote: > - while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:v"))) { > + while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:vi:"))) { how about keeping alphabetical order here > switch (c) { > case 'a': > oneshot = atoi(optarg); > @@ -209,6 +211,9 @@ int main(int argc, char *argv[]) > case 't': > adjtime = atoi(optarg); > break; > + case 'i': > + index = atoi(optarg); > + break; and here? > case 'h': > usage(progname); > return 0; [ Yes, the 'h' is out of order. Pleae fix that, too, if you want to. ] Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists