netdev - RE: Patchset - Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BF3270C86E8B1349A26C34E4EC1C44CB2C86E05F@CMEXMB1.ad.emulex.com>
Date:	Wed, 5 Feb 2014 12:20:21 +0000
From:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	Amir Vadai <amirv@...lanox.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: RE: Patchset - Support for configurable RSS hash key



> -----Original Message-----
> From: Amir Vadai [mailto:amirv.mellanox@...il.com] On Behalf Of Amir
> Vadai
> Sent: Sunday, February 02, 2014 9:40 PM
> To: Venkata Duvvuru
> Cc: netdev@...r.kernel.org; Ben Hutchings
> Subject: Re: Patchset - Support for configurable RSS hash key
> 
> On 17/01/14 13:02 +0000, Venkata Duvvuru wrote:
> > NIC drivers that support RSS use either a hard-coded value or a random
> value for the RSS hash key. Irrespective of the type of the key used, the user
> would want to change the hash key if he/she is not satisfied with the
> effectiveness of the default hash-key in spreading the incoming flows evenly
> across the RSS queues.
> >
> > This patch set provides support for configuring the RSS hash-key via the
> ethtool interface.
> >
> > The patch set consists of:
> > a) ethtool user-land patches
> > b) ethtool kernel patch
> > c) be2net patch that implements the ethtool hooks
> 
> Hi,
> 
> I would be happy to add support in setting the hash function in addition to
> the hash key.
> 
> Mellanox NIC's have support in 2 hash functions: Toplitz and XOR.
> 
> Let me if you can add it to your patchset or would like me to send a patch on
> top of yours to add it.

I would prefer you to add the proposed changes on top my patchset. I'm working on the review comments currently and I will post the patchset once the patches are ready.

> 
> Thanks,
> Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html