[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHA+R7NkLnh5xpca7nQbf99kAqqLW4trR4AEKXgn3Oad6_NBjg@mail.gmail.com>
Date: Thu, 6 Feb 2014 14:18:14 -0800
From: Cong Wang <cwang@...pensource.com>
To: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc: Stephen Hemminger <stephen@...workplumber.org>,
netdev <netdev@...r.kernel.org>
Subject: Re: Fw: [Bug 70071] New: Sending netconsole messages over a bridged
network interface doesn't work anymore
On Thu, Feb 6, 2014 at 12:52 AM, Toshiaki Makita
<makita.toshiaki@....ntt.co.jp> wrote:
> (2014/02/06 15:49), Cong Wang wrote:
>> On Wed, Feb 5, 2014 at 9:44 PM, Toshiaki Makita
>> <makita.toshiaki@....ntt.co.jp> wrote:
>>> Tested this patch with latest net-tree and netconsole works with it.
>>> But I thinks it is better to move that "if" to br_add_if() because if we
>>> don't have npinfo, we don't have to alloc p->np in br_add_if(), right?
>>>
>>
>> Hmm, we shouldn't handle netpoll-specific code inside br_add_if(),
>> we probably need the attached patch instead. Please give it
>> a try, or I will test it tomorrow, it's too late here.
>>
>
> I tested whether netconsole works and whether it can be built
> with/without CONFIG_NET_POLL_CONTROLLER, and couldn't find any problem.
> This looks good to me.
>
Excellent! I will send it formally.
Thanks for testing!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists